From 2a66bdc1022d2afd02499fd652dc0908d31add2a Mon Sep 17 00:00:00 2001
From: MarcZX10 <67475268+MarcZX10@users.noreply.github.com>
Date: Sat, 31 Oct 2026 12:46:04 +0000
Subject: [PATCH] test(tools): cover the default base order and its errors

---
 CMakeLists.txt               |  2 ++
 tools/tests/test_base_ref.py | 68 ++++++++++++++++++++++++++++++++++++
 2 files changed, 70 insertions(+)
 create mode 100644 tools/tests/test_base_ref.py

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 46ae51765d..fe11f7c60b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -271,6 +271,8 @@ if(BUILD_TESTING)
         set_tests_properties(preview_pad_timeline PROPERTIES TIMEOUT 20)
         add_test(NAME conventions_git_errors COMMAND ${Python3_EXECUTABLE}
             ${CMAKE_CURRENT_SOURCE_DIR}/tools/tests/test_check_conventions_git.py)
+        add_test(NAME tools_base_ref COMMAND ${Python3_EXECUTABLE}
+            ${CMAKE_CURRENT_SOURCE_DIR}/tools/tests/test_base_ref.py)
         add_test(NAME tools_configure_diff COMMAND ${Python3_EXECUTABLE} ${CMAKE_SOURCE_DIR}/tools/tests/test_compare_configure_checks.py)
         set_tests_properties(tools_configure_diff PROPERTIES TIMEOUT 20)
         add_test(NAME conventions_doc_links COMMAND ${Python3_EXECUTABLE}
diff --git a/tools/tests/test_base_ref.py b/tools/tests/test_base_ref.py
new file mode 100644
index 0000000000..413578f4bc
--- /dev/null
+++ b/tools/tests/test_base_ref.py
@@ -0,0 +1,68 @@
+import os
+import subprocess
+import sys
+import tempfile
+import unittest
+from pathlib import Path
+
+sys.path.insert(0, str(Path(__file__).resolve().parents[1]))
+import base_ref
+
+
+class BaseRefTests(unittest.TestCase):
+    def setUp(self):
+        directory = tempfile.TemporaryDirectory()
+        self.addCleanup(directory.cleanup)
+        self.repo = Path(directory.name)
+        self.git("init", "-q")
+
+    def git(self, *arguments):
+        environment = {**os.environ, "GIT_CONFIG_NOSYSTEM": "1"}
+        result = subprocess.run(["git", "-C", str(self.repo), "-c", "user.name=Base Ref Test",
+                                 "-c", "user.email=test@example.com", "-c", "commit.gpgsign=false", *arguments],
+                                capture_output=True, text=True, check=True, env=environment)
+        return result.stdout.strip()
+
+    def commit(self, subject):
+        self.git("commit", "-q", "--allow-empty", "-m", subject)
+        return self.git("rev-parse", "HEAD")
+
+    def point(self, ref, commit=None):
+        if commit is None:
+            self.git("update-ref", "-d", ref)
+        else:
+            self.git("update-ref", ref, commit)
+
+    def test_upstream_main_is_preferred_over_a_stale_origin_main(self):
+        stale = self.commit("first")
+        current = self.commit("second")
+        self.point("refs/remotes/origin/main", stale)
+        self.point("refs/remotes/upstream/main", current)
+        self.point("refs/heads/main", current)
+        self.assertEqual(base_ref.resolve(self.repo), "upstream/main")
+
+    def test_origin_main_is_used_without_an_upstream_remote(self):
+        commit = self.commit("first")
+        self.point("refs/remotes/origin/main", commit)
+        self.point("refs/heads/main", commit)
+        self.assertEqual(base_ref.resolve(self.repo), "origin/main")
+
+    def test_local_main_is_the_last_resort(self):
+        commit = self.commit("first")
+        self.point("refs/heads/main", commit)
+        self.assertEqual(base_ref.resolve(self.repo), "main")
+
+    def test_an_explicit_base_is_returned_unchecked(self):
+        self.commit("first")
+        self.assertEqual(base_ref.resolve(self.repo, "release/1.0"), "release/1.0")
+
+    def test_no_base_branch_names_every_candidate(self):
+        self.commit("first")
+        with self.assertRaises(ValueError) as caught:
+            base_ref.resolve(self.repo)
+        for candidate in base_ref.CANDIDATES:
+            self.assertIn(candidate, str(caught.exception))
+
+
+if __name__ == "__main__":
+    unittest.main()