From eb5d6b02c819da0dee084288cb5525257576726f Mon Sep 17 00:00:00 2001 From: MarcZX10 <67475268+MarcZX10@users.noreply.github.com> Date: Mon, 2 Nov 2026 14:46:20 +0000 Subject: [PATCH] docs(dev): correct abort scope of APS5_TRACE_CALLS Old wording (docs/dev/TRACING.md:14): crash and abort reports (abort only on Linux and macOS) include the last 64 calls Correct wording: crash and abort reports include the last 64 calls Evidence on upstream/main: - core/libs/prx/libc/src/specifics/windows/CrashReport.cpp:656-657: AbortSignalHandler calls ReportBacktrace("abort() (SIGABRT)", true) - core/libs/prx/libc/src/specifics/windows/CrashReport.cpp:678: std::signal(SIGABRT, AbortSignalHandler) registers it on Windows - core/libs/prx/libc/src/specifics/windows/CrashReport.cpp:651: ReportBacktrace calls ReportCallTrace() - core/libs/prx/libc/src/specifics/x86_64/CallTrace.cpp:358-363 and 386-391: the Linux and macOS abort report also calls ReportCallTrace() --- docs/dev/TRACING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/dev/TRACING.md b/docs/dev/TRACING.md index b9a5f8aa59..e0bac89156 100644 --- a/docs/dev/TRACING.md +++ b/docs/dev/TRACING.md @@ -11,7 +11,7 @@ Set a switch before starting the emulator. Unless noted, any value enables it. M | `APS5_TRACE_APR` | APR file reads, including path, offset, size and destination. | | `APS5_TRACE_AUDIOOUT` | Audio output port parameters when a port is opened. | | `APS5_TRACE_AUDIOOUT2` | AudioOut2 context and port parameters, attributes, pushes, queue polls and periodic queue summaries. | -| `APS5_TRACE_CALLS` | On Windows, Linux and macOS, records calls to the imports selected by this comma-separated library list (or `all`); crash and abort reports (abort only on Linux and macOS) include the last 64 calls and most-called imports. The executable must be converted with `--trace-imports`; see [Usage](../user/USAGE.md#tracing-system-library-calls). | +| `APS5_TRACE_CALLS` | On Windows, Linux and macOS, records calls to the imports selected by this comma-separated library list (or `all`); crash and abort reports include the last 64 calls and most-called imports. The executable must be converted with `--trace-imports`; see [Usage](../user/USAGE.md#tracing-system-library-calls). | | `APS5_TRACE_CALLS_FILE` | With `APS5_TRACE_CALLS`, a file rewritten every 10 seconds with every traced import called so far, most called first: number of calls, library and import name. | | `APS5_TRACE_EXIT` | Guest `exit` and `_Exit` calls and process-exit backtraces. | | `APS5_TRACE_FIBER` | Fiber initialization, switches and returns. |