Dean
6113756582
Merge pull request #12979 from xXPBSXx/tools/q4-checkconv-event-recursion
...
fix(tools): report deeply nested event JSON in check_conventions as a usage error
2026-11-03 06:26:03 +13:00
MarcZX10
5ed9f90bdc
fix(tools): check against upstream/main by default in check_conventions
2026-10-31 12:46:04 +00:00
Adrià
021158897d
Merge pull request #9966 from jotitadev/fix/conventions-function-body-stop-at-close
...
fix(tools): stop masking a function body window once its brace closes
2026-10-30 00:28:07 +01:00
xXPBSXx and Claude Sonnet 5.5
e6ddf01fa5
fix(tools): report deeply nested event JSON in check_conventions as a usage error
...
Co-Authored-By: Claude Sonnet 5.5 <[email protected]
2026-10-29 17:44:58 +01:00
Jota
1c968013ed
Merge main into fix/conventions-function-body-stop-at-close
2026-10-28 22:51:53 -03:00
Zain
470511472d
fix(tools): scope ABI alias expansion to export checks
2026-10-29 02:25:24 +01:00
Zain
6bf519c5db
fix(tools): check exports through local ABI aliases
2026-10-29 02:25:24 +01:00
Dean
b4d1151aad
Merge pull request #12196 from rooklz/fix/check-conventions-input-errors
...
fix(tools): report unreadable --body and --event inputs in check_conventions as usage errors
2026-10-28 22:51:50 +13:00
Adrià
498954ef0e
Merge pull request #11375 from veosett/codex/conventions-angle-links
...
fix(tools): recognize angle-wrapped documentation links
2026-10-28 05:49:59 +01:00
rooklz
72eb12c5c1
fix(tools): report unreadable --body and --event inputs in check_conventions as usage errors
2026-10-28 03:10:29 +00:00
Dean
b5442a8a5f
Merge pull request #10776 from hundoukam/fix/debt-file-entry
...
fix(tools): place a debt entry by the first core link of its whole entry
2026-10-27 18:28:04 +13:00
Dean
60f36a2dfb
Merge pull request #10982 from MarcZX10/marc/feat-template-heading-messages
...
feat(tools): say which pull request template heading is missing, empty or misspelled
2026-10-27 05:34:54 +13:00
Kovalev Vladislav
947e459037
fix(tools): recognize angle-wrapped documentation links
2026-10-26 16:08:13 +06:00
MarcZX10
f32db390de
feat(tools): name a template heading written at another level or case
...
The template check only reads '### Name' headings, so '## What', '#### Tested' or '### checklist' counted as missing, and the finding did not say why. When a section is missing, look for the same name as a heading at any level and in any case, and add it to the finding, as in "add the '### What' heading of the template; found '## What'".
2026-10-25 13:08:23 +00:00
MarcZX10
ed7f5833ab
feat(tools): tell a missing pull request template heading from an empty section
...
The pull request template check reported 'section What is missing or empty' both when the body had no '### What' heading and when the heading was there with nothing under it, without saying which heading it looks for. Report 'add the ### What heading of the template' when the heading is absent and 'fill the ### What section' when it is empty, for What, Tested and Checklist.
2026-10-25 13:08:23 +00:00
Braxton Atkinson
2f975066cd
fix(tools): parse flow-style pull-request filter keys safely
2026-10-24 23:26:59 -05:00
hundoukam and Claude Fable 5.1
147ae14830
fix(tools): place a debt entry by the first core link of its whole entry
...
The debt-file rule read only the first line of an added entry, so an
entry whose first core/ link sat on an indented continuation line was
rejected in docs/dev/debt/<name>.md and accepted in the index, the
opposite of what debt_split.py does with the same entry. The rule now
joins the continuation lines as debt_split.parse does before naming
the file.
Co-Authored-By: Claude Fable 5.1 <[email protected]
2026-10-24 17:58:17 -06:00
Guille Dols
6fb15480a5
ci(conventions): keep namespace identity across reopened blocks for alignas constants
2026-10-24 20:33:30 +02:00
Guille Dols
3b4c56757c
ci(conventions): resolve alignas constants in the scope they are used in
2026-10-24 20:33:30 +02:00
Guille Dols
a2b2c374ed
ci(conventions): reject alignas above the 8192 bytes MinGW allows
2026-10-24 20:33:30 +02:00
Dean
5a1e51137f
Merge pull request #9660 from jotitadev/fix/conventions-env-reference-from-subdirectory
...
fix(tools): check environment references from a subdirectory
2026-10-23 19:26:22 +13:00
Jota
db01701db5
perf(tools): stop masking a function body window once its brace closes
...
function_body masked the whole 400-line window after every export even
when the body closes on the same line. With 2000 exports in one file the
large export set test spent about 6 s there, which made
conventions_function_bodies_shard_11 ten times slower than any other
shard and the one that times out most often under CI load.
Walk the CPP_TOKEN matches of the same window lazily and stop at the
closing brace. re.sub joins the unmatched gaps and the masked matches in
order, so the masked text up to that brace is the same as before.
2026-10-22 21:28:53 -03:00
fma-rc
928588bbb8
fix(tools): compare libraries before looking for a duplicate export's body
2026-10-23 00:01:52 +02:00
Jota
a22f220857
fix(tools): check environment references from a subdirectory
2026-10-22 03:45:02 -03:00
fma-rc
3b5a99c20f
fix(tools): count assembly exports in the duplicate-export check
2026-10-22 00:28:31 +02:00
boykopovar
a6dcea9279
Merge pull request #9137 from boykopovar/fix/funcs-abi-debt-2026-10-20
...
fix(libs): libs funcs abi debt 2026 10 20
Corrected signatures or behaviour of 1,702 existing exported functions across 96 libraries. Added 85 typed export wrappers. Unimplemented functions retain NotImplemented_nid_no_patch(__func__).
2026-10-22 00:32:11 +03:00
Adrià
1896871ba7
Merge pull request #8892 from harisibrar1/ci/conventions-current-base
...
ci(conventions): check pull requests with the current base branch rules
2026-10-21 21:12:55 +02:00
boykopovar
68aeef249a
fix(tools): scan committed sources for duplicate exports
2026-10-21 21:56:08 +03:00
Dean
c68a27cc4c
Merge pull request #8638 from Tripchipp/fix/doc-links-inline-code-labels
...
fix(tools): check doc links whose text is inline code
2026-10-21 17:54:13 +13:00
harisibrar1 and Claude Opus 5.5
0c7d25c3d1
ci(conventions): check pull requests with the current base branch rules
...
The workflow checked out pull_request.base.sha, the base recorded when the
pull request was opened, and ran that revision's check_conventions.py. A rule
merged after a pull request was opened never ran on it: #7005 added
APS5_NO_WGI without an ENVIRONMENT.md row and passed with the checker of
07e741481[email protected]
2026-10-21 00:50:41 -04:00
Tripchipp
e58fcc9c3b
fix(tools): check doc links whose text is inline code
2026-10-20 21:05:11 +02:00
Maz
6926aff808
fix(tools): stream duplicate export search patterns
2026-10-20 16:58:16 +04:00
Cankiee
445d7192f9
fix(tools): handle git command failures gracefully
2026-10-20 11:52:58 +02:00
Adrià
c74aeb2f4c
Merge pull request #6757 from LeandroLP23/ci/conventions-debt-entry-length
...
feat(tools): warn when a pull request adds a technical debt entry over 1000 characters
2026-10-19 12:17:54 +02:00
Adrià
8e3d8b9bd8
Merge pull request #6723 from Tripchipp/fix/debt-file-unlinked-entries
...
fix(tools): keep debt entries without a core link in the index
2026-10-19 12:09:51 +02:00
LeandroLP23 and Claude Opus 5.5
fb1ad2fcf4
feat(tools): warn when a pull request adds a technical debt entry over 1000 characters
...
Co-Authored-By: Claude Opus 5.5 <[email protected]
2026-10-18 23:48:11 +02:00
David Fontanet Bujaldón and Claude Opus 5.5
c494367836
Merge boykopovar/AnyPS5 main into fix/conventions-unknown-nid-collisions
...
Co-Authored-By: Claude Opus 5.5 <[email protected]
2026-10-18 13:17:36 +02:00
011010
061101a3e8
fix(tools): report a row the pull request removes
2026-10-18 04:16:04 -06:00
011010
ea01ee8965
fix(tools): check the environment names a pull request adds
2026-10-18 02:36:16 -06:00
011010
bb109df676
fix(tools): read the helper and wide-string environment readers
2026-10-18 02:13:39 -06:00
husari.orozco
abec10fe2d
fix(tools): catch the EnvInt and GetEnvironmentVariableA readers and take the review rows
2026-10-18 01:14:35 -06:00
husari.orozco
d49b0fecf5
docs(environment): add the APS5_* and ANYPS5_* reference and check it
2026-10-18 01:14:35 -06:00
Dean
fdcc9f70e0
Merge pull request #5780 from MrMha/fix/conventions-duplicate-source-tokens
...
Merged while @adriadam10 is away; his requested change is in place.
2026-10-18 15:57:48 +13:00
Dean
e14e281c82
Merge pull request #6624 from IshmamDC217/fix/conventions-multiline-string-comments
...
fix(tools): find Python and CMake comments across multi-line strings
2026-10-18 12:56:50 +13:00
MrMha
26c3a82e8d
fix(conventions): ignore non-code duplicate export matches
2026-10-17 18:08:43 +04:00
Dean
661a1118cc
Merge pull request #6626 from IshmamDC217/fix/conventions-ci-gate-indent
...
fix(tools): read workflow job keys at the indentation the file uses
2026-10-17 18:00:57 +13:00
Dean
10e0906273
Merge pull request #6407 from MarcZX100/codex/conventions-duplicate-export-quotepath-6388
...
fix(tools): keep duplicate export paths unquoted
2026-10-17 17:55:52 +13:00
Dean
4e15bde13d
Merge pull request #6397 from MarcZX100/codex/conventions-crlf-fences-6387
...
fix(tools): recognize markdown fences with CRLF endings
2026-10-17 16:37:26 +13:00
AlxcBTW
ad2b2b4c9c
docs: add AGENTS.md with the rules coding agents break
2026-10-16 19:41:49 +02:00
Tripchipp
bd9d0c3d7d
fix(tools): keep debt entries without a core link in the index
2026-10-16 09:09:21 +02:00
Dean