Culprits #11725 (guest_timed_wait_cpu) and #12788 (web_library_assets), run 41054424215.
guest_timed_wait_cpu aborted on a latency bound on a loaded runner (max overshoot 3.8 ms already
in the 100 us case); Linux bounds are now 10 ms p99 / 50 ms max, Windows keeps its own.
test_invalid_archive_entries_are_rejected resolved a historical revision with git, which the
shallow CI checkout on Windows lacks; it now patches release_web_files like its siblings.
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Its default is F9 alone, it is keyboard-only (mouse buttons and the
wheel are errors), serializes and imports like the other utility
actions, warns when another action takes F9 until it moves off, and no
other built-in input uses F9.
A rebindable keyboard action, F9 by default, that asks for the
controller status panel. F9 is the first free function key: F7, F10,
F11 and F12 are bound by default and no default keyboard-to-pad binding
uses it. Like ToggleFullscreen, TogglePerformanceOverlay and Screenshot
it accepts only keyboard keys, fires once per press (not on key repeat)
and does not press any pad button.
The input mapper's catalogue gets the action, its F9 default and its
keyboard-only restriction, and its existing source-contract tests list
it, since they compare the actions, restrictions and built-in bindings
with the native files.
After --, the next argument is the command even when it contains =;
taking -- as one more option would read compiler=tools/g++ as an
assignment and refuse -c. Suggested by veosett in review.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
A compiler whose arguments happen to begin with -E env keeps the
ordinary rewrite; without the stem check it was taken for the launcher
and refused -c. Suggested by rooklz in review.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
CMake writes a launcher that sets environment variables as a leading
`cmake -E env NAME=VALUE ... <launcher> <compiler>`, as the AGC
execution tests' ccache launcher does. check_compile took cmake for the
compiler, inserted -fsyntax-only before -E and dropped -E as a
preprocessing option, so every such source failed with
"CMake Error: Unknown argument". Keep the env prefix (NAME=VALUE,
--unset=, --modify and --) and rewrite only the command after it;
reject its other options and a prefix without a command.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Review of the first cut: a production-only core/libs edit no-ops before
building libs, so the libs build is now driven by whether the change
reaches core/libs at all and runs even when no test source changed.
ctest name resolution took the last command element, which is a test
argument for parameterized registrations; the executable is now
resolved by position and suffix, partial target-to-test coverage is
rejected instead of silently running a subset, the -R pattern is fully
escaped and ctest runs with --no-tests=error. The tool's unit tests are
registered with add_test beside the host-only tool's, and main now
propagates libs build and ctest failures as exit 1.
Pull requests only link the host-only core/libs test executables and
never run a guest test, so the three guest_pad test aborts in
#12308-#12310 reached review with every check green. The windows pull
request job now builds the libs target and runs the guest tests whose
sources changed, mirroring the host-only selection; changes that
cannot reach core/libs keep the job light with an early no-op.
