strncat_s and wcsncat_s return ERANGE with the "buffer too small" message
when the destination has no terminator within destsz, and strncat_s leaves
the terminators out of its overlap ranges, as the PPSA31872 libc.prx code
does. strcat_s and wcscat_s keep the measured EINVAL.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
No test called strlcpy. GuestStrings now checks it as FreeBSD's strlcpy(3)
defines it: the result is strlen(src); at most size - 1 bytes are copied
and the copy is NUL-terminated (a source that fits, one truncated to
size 4, an exact fit and size 1); size 0 leaves the destination alone;
an empty source gives an empty string. Bytes after the terminator stay
untouched.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
bcmp returned memcmp's result, so differing bytes gave -1 or 1 by their
order. The libc.prx bundled with titles returns only 0 or 1: 1 whenever
the first n bytes differ, whichever argument holds the larger byte. The
test now requires 1 for both argument orders.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
When the transformed string does not fit, strxfrm and wcsxfrm wrote
count - 1 characters and a terminator. The libc.prx bundled with titles
copies the first count characters and writes no terminator, as a plain
copy of count units would, and copies the terminator only when the whole
result fits. Both functions now do the same; the return value, the
length of the source, is unchanged. The tests that expected the
terminated prefix expect the measured units instead.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
The empty string that the titles' libc.prx leaves in the saved pointer
when no token is left lies in a read-only PT_LOAD segment (R--) of all
eleven measured titles, for strtok_r and for wcstok, so a write through
the pointer faults there. The arrays are now const and stored as char*.
The tests compare pointers into unrelated arrays with std::less, and
the wcstok test overwrites the old terminator and resumes, as the
strtok_r test does.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
strtok_r set the saved pointer to NULL after the last token and when no
token was left, as FreeBSD 11.4 does (#4625). The libc.prx bundled with
titles leaves it at the string's terminator after a last token that ends
the string, so a later call continues from there, and points it at a
static empty string when no token is left, so later calls keep
returning NULL. strtok, which runs strtok_r on its own state, follows.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
strcoll called the host's strcmp, which returns -1, 0 or 1 on Windows.
The libc.prx bundled with eleven titles returns, in the C locale, the
difference of the unsigned bytes at the first mismatch, as its strcmp
does; strcoll now computes that.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
strcasecmp and strncasecmp returned the folded unsigned-byte difference,
following FreeBSD 11.4's strcasecmp.c (#3966, #9642). The libc.prx bundled
with eleven titles returns -1, 0 or 1, the sign of that difference; both
functions now do the same, and the byte-pair tests expect it.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
strcpy_s, strncpy_s, strcat_s, strncat_s, memcpy_s and memmove_s take RSIZE_MAX as 2^61 - 1, return EINVAL above it, call the constraint handler on every violation, and strcat_s returns EINVAL for an unterminated destination.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
guest_strings checked the bounds-checked and BSD string functions but not
the plain C ones. It now checks strcmp, strncmp and strcoll by sign,
strlen, strcpy and strcat return values, strncpy zero padding and its
unterminated truncation, strstr with an empty needle, strspn, bcmp and
bzero.
CheckSscanfS was empty on Windows because its whole body sat under
#ifndef _WIN32. The 13 checks pass there, so they run on every host.
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
strrchr passed its int argument to the host strrchr unchanged. On Windows the
host compares it with the signed char bytes of the string, so a byte of 0x80 to
0xFF passed as an unsigned value (0xE9) or a value above 255 (0x12F) was not
found, where FreeBSD converts the argument to char first.
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Dean