Commit Graph
60 Commits
Author SHA1 Message Date
rooklz c2ffdbdab6 fix(tools): use realpath for check_compile syntax-only source path 2026-10-30 16:34:42 +00:00
Adrià e628c03830 Merge pull request #12971 from GiannisG1/fix/check-compile-cmake-env-wrapper
fix(tools): check sources whose compile command runs through cmake -E env
2026-10-30 10:19:00 +01:00
Adrià 66b8e907e4 Merge pull request #12161 from dantdmdarealguy/test/check-compile-split-mode-cases
test(check-compile): split the two-variant mode cases and the invalid entry case
2026-10-30 00:23:02 +01:00
GiannisandClaude Opus 5.5 b3b4037585 test(tools): keep a command path containing = after the cmake -E env delimiter
After --, the next argument is the command even when it contains =;
taking -- as one more option would read compiler=tools/g++ as an
assignment and refuse -c. Suggested by veosett in review.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-30 00:13:31 +02:00
GiannisandClaude Opus 5.5 4ebd5c3a11 test(tools): check that only cmake starts a cmake -E env prefix
A compiler whose arguments happen to begin with -E env keeps the
ordinary rewrite; without the stem check it was taken for the launcher
and refused -c. Suggested by rooklz in review.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-29 20:19:24 +02:00
GiannisandClaude Opus 5.5 151625b9d2 fix(tools): check sources whose compile command runs through cmake -E env
CMake writes a launcher that sets environment variables as a leading
`cmake -E env NAME=VALUE ... <launcher> <compiler>`, as the AGC
execution tests' ccache launcher does. check_compile took cmake for the
compiler, inserted -fsyntax-only before -E and dropped -E as a
preprocessing option, so every such source failed with
"CMake Error: Unknown argument". Keep the env prefix (NAME=VALUE,
--unset=, --modify and --) and rewrite only the command after it;
reject its other options and a prefix without a command.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-29 19:55:22 +02:00
rooklz b9ec5081e2 fix(tools): report check_compile symbolic link loops as usage errors 2026-10-28 23:34:17 +00:00
Dean c9520deefe Merge pull request #11522 from StoneDC/fix/check-compile-driver-modes
fix(tools): reject compiler driver queries during syntax checks
2026-10-29 12:06:04 +13:00
dantdmdarealguy 0ffc36fb95 test(check-compile): split the two-variant mode cases and the invalid entry case
Each two-variant check_compile_modes case now runs one variant, and the
invalid compilation database entry case runs in four groups through a
shared helper. The same control compiles and check_compile runs are made.
2026-10-28 11:00:00 -05:00
Dean ef7515f071 Merge pull request #12119 from dantdmdarealguy/test/check-compile-slow-cases
test(check-compile): keep slow syntax check cases within the CI time limit
2026-10-28 22:48:16 +13:00
Dean e6d54e4f44 Merge pull request #11928 from shurhundo/test/restore-response-output-coverage
test(check-compile): restore response output preservation coverage
2026-10-28 22:31:39 +13:00
dantdmdarealguy f8ddd30ce1 test(check-compile): keep slow syntax check cases within the CI time limit
test_library_directory_values_can_look_like_modes passed -L -E as mode
flags, so check_modes took the -E for a preprocessing mode and dropped -c.
Its control commands linked an executable with each compiler, which on
the Windows runner goes through link.exe; the case took about twice as
long as its -I -E counterpart and timed out in 6 Windows CI jobs. The
-L -E pair now goes through configure like the include directory case,
so the control only compiles. The command check_compile checks is the
same, since it drops -c.

test_response_options_compile_without_changing_build_outputs ran 30
check_compile invocations in one case. Its six response files are now
checked by three cases of two.
2026-10-27 16:45:03 -05:00
rooklz fe80227fce fix(tools): reject unmodeled save-temps modes in syntax checks 2026-10-27 10:14:45 +00:00
Queuze 4564b15ee1 test(tools): restore response output preservation coverage 2026-10-27 13:46:32 +08:00
StoneDC 6c247b1b21 fix(tools): reject compiler driver queries during syntax checks 2026-10-27 10:31:25 +08:00
Kovalev Vladislav 88140fb881 test(tools): preserve Clang saved temporary fixtures 2026-10-25 20:18:35 +01:00
Kovalev Vladislav 9fc0a99dac test(tools): split syntax check suites within CI time limit 2026-10-25 20:18:35 +01:00
Kovalev Vladislav 560a06febe test(tools): respect compiler handling of unknown save modes 2026-10-25 20:18:35 +01:00
Kovalev Vladislav 19db55c64b fix(tools): strip save-temps flags from syntax checks 2026-10-25 20:18:35 +01:00
Queuze e5fcbb775d fix(check-compile): enforce syntax mode 2026-10-24 21:31:23 -03:00
Queuze 348c6fd80b test(check-compile): combine syntax fixes 2026-10-24 21:18:08 -03:00
Queuze b38b41aa8a fix(check-compile): enforce syntax mode 2026-10-24 21:10:27 -03:00
Queuze ed3eb27141 test(check-compile): cover forwarded rsp flags 2026-10-24 20:16:41 -03:00
Queuze dc15446739 fix(check-compile): reject text-mode ambiguities 2026-10-24 20:15:22 -03:00
Queuze e9ff1cd371 test(check-compile): shard syntax check cases 2026-10-24 20:00:42 -03:00
Queuze a0f155e10f chore: combine response and output safety tests 2026-10-24 19:22:32 -03:00
Queuze 034bc58613 fix(check-compile): parse GNU response options 2026-10-24 19:21:38 -03:00
Queuze f3657ab232 test(check-compile): cover response option tokens 2026-10-24 19:13:05 -03:00
shurhundo 7221249a9a fix(check-compile): expand response files recursively with cycle and depth protection 2026-10-24 21:53:05 +08:00
shurhundo f12344718a fix(check-compile): expand response files before syntax checks 2026-10-24 15:45:44 +08:00
Luka Petrovic a0ce5788b3 fix(tools): validate compilation database entries 2026-10-23 19:38:59 +02:00
Kovalev Vladislav 9780aa25a7 test(tools): preserve Clang saved temporary fixtures 2026-10-23 12:18:01 +06:00
Kovalev Vladislav b874dc57b9 test(tools): split syntax check suites within CI time limit 2026-10-23 12:15:22 +06:00
Kovalev Vladislav 6229cd07eb test(tools): respect compiler handling of unknown save modes 2026-10-23 12:15:22 +06:00
Kovalev Vladislav 34349949dd fix(tools): strip save-temps flags from syntax checks 2026-10-23 12:15:22 +06:00
emirplus 8cded11b59 fix(tools): decode compile commands JSON with utf-8-sig in check_compile 2026-10-21 21:41:47 +03:00
Dean aac52270ff Merge pull request #8515 from xTRACKGOD/fix/tools-check-compile-external-sources
fix(tools): find compile commands for sources outside checkout
2026-10-21 17:47:53 +13:00
xTRACKGOD dc9a15aede fix(tools): find compile commands for sources outside checkout 2026-10-20 19:58:22 +05:30
Henryisdjfunkyho 42701b2906 fix(tools): reject unexpanded response files in syntax checks 2026-10-19 22:49:45 -07:00
Dean d6b03aa8fa Merge pull request #8031 from orezraey/fix/check-compile-ninja-encoding
fix(tools): decode check_compile's Ninja commands in the build-file encoding
2026-10-20 18:33:55 +13:00
Dean a020d02560 Merge pull request #7718 from To3akaRin/codex/fix-syntax-check-dependency-flags
fix(tools): strip dependency options before syntax checks
2026-10-20 15:53:38 +13:00
orezraeyandClaude Opus 5.5 6c039bd3e2 fix(tools): report a failed Ninja wincodepage query in check_compile
Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-19 15:10:53 -03:00
orezraeyandClaude Opus 5.5 26a7d9c8ec fix(tools): decode check_compile's Ninja commands in the build-file encoding
Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-19 15:10:52 -03:00
To3akaRin 7e8aa10ae6 fix(tools): strip dependency options before syntax checks 2026-10-19 10:43:00 +08:00
MrMha 3e906dce25 feat: run independent syntax checks with configurable concurrency 2026-10-18 10:17:24 +04:00
Kaua 316ad40b46 fix(tools): write check_compile output as UTF-8 2026-10-17 21:07:01 -03:00
Dean 027cc4efc9 Merge pull request #6577 from GalaxyGamingFR/fix/check-compile-merge-base
fix(check_compile): take changed units from the merge base
2026-10-18 12:56:47 +13:00
Dean f25a3d8596 Merge pull request #7232 from Lyrilika/fix/check-compile-all-configurations
fix(tools): check every compilation configuration
2026-10-18 10:12:15 +13:00
Lyrilika 6f4ffeecc0 fix(tools): check every compilation configuration 2026-10-17 20:17:55 +02:00
MrMha d33f0371a2 fix: expand Ninja response files before syntax checks 2026-10-17 18:39:37 +04:00