Dean
57ae26b917
Merge pull request #14353 from DonRyuzaki/fix/tools-annotate-elf-layout
...
fix(tools): validate supported ELF header layout
2026-11-06 22:17:01 +13:00
Dean
534113181a
Merge pull request #14114 from ArekatlaNishanthchowdary/fix/tools-annotate-module-probe-objdump-once
...
fix(tools): probe for GNU objdump once per annotate_module run
2026-11-06 21:12:29 +13:00
Dean
ee4deb21a9
Merge pull request #15085 from JJenkx/windows/annotate-module-timeout
...
test(tools): run each annotate_module case as its own test
2026-11-05 21:46:52 +13:00
pushkarreddyy
0f6036e876
test(tools): skip annotate_module CLI alias test when GNU objdump is unavailable
2026-11-04 23:14:50 +05:30
Dean
c955a63d3d
Merge pull request #14352 from DonRyuzaki/fix/tools-annotate-dynamic-span
...
fix(tools): bound dynamic tags to their segment
2026-11-03 08:48:57 +13:00
JJenkx and Claude Opus 5.5
0afa27db8a
test(tools): run each annotate_module case as its own test
...
Instead of raising annotate_module's timeout, register every case of
test_annotate_module.py as its own CTest test with the 20 s limit, as
trace_digest does. The first case keeps the annotate_module name and is
chosen through ANNOTATE_MODULE_TEST; the others are named
annotate_module_<class>_<case>.
Co-Authored-By: Claude Opus 5.5 <[email protected]
2026-11-02 11:56:05 -05:00
Henryisdjfunkyho
b9b4efa265
fix(tools): reject looping annotation output paths
2026-11-02 07:55:47 -08:00
Arekatla Nishanth Chowdary
58fe832f23
fix(tools): probe for GNU objdump once per annotate_module run
...
gnu_objdump() ran `objdump --version` for every candidate name on each
call, and annotate_module calls it once from main and again for every
executable segment it disassembles. On Windows each probe is a process
start, and the in-process annotate_module tests run the tool about a
hundred times: the file took 13-14 s of its 20 s ctest TIMEOUT idle and
timed out under load. Cache the result for the process. The tests that
change what a probe finds, the discovery tests and the relative PATH
entry test, clear the cache around their lookups.
2026-11-02 21:00:01 +05:30
Dean
0cad215e62
Merge pull request #12245 from Henryisdjfunkyho/fix/annotate-output-collisions
...
fix(tools): reject aliased annotation reports
2026-11-03 02:36:04 +13:00
Ryuzaki
719cd6e8df
fix(tools): preserve missing dynamic diagnostic
2026-11-01 14:40:09 +00:00
Ryuzaki
7007a66de7
fix(tools): validate supported ELF header layout
2026-11-01 10:07:53 +00:00
Ryuzaki
1a58d5d198
fix(tools): bound dynamic tags to their segment
2026-11-01 10:07:28 +00:00
Adrià
3e33cdafdc
Merge pull request #13830 from CodingBreadd/fix/annotate-module-objdump-relative-path
...
fix(tools): pass objdump a relative path in annotate_module
2026-11-01 03:10:49 +01:00
Darius and Claude Opus 5.5
7cded03b58
fix(tools): run a relatively found objdump by its absolute path
...
Co-Authored-By: Claude Opus 5.5 <[email protected]
2026-10-31 15:42:56 +02:00
Adrià
82217a79db
Merge pull request #13619 from PolkadotDom/fix/annotate-symbol-visibility
...
fix(tools): exclude private symbols from export annotations
2026-10-31 10:28:47 +01:00
Darius and Claude Opus 5.5
c6481e6f34
fix(tools): pass objdump a relative path in annotate_module
...
Co-Authored-By: Claude Opus 5.5 <[email protected]
2026-10-31 06:27:48 +02:00
Adrià
11df2a6ca8
Merge pull request #13535 from ArekatlaNishanthchowdary/test/tools-annotate-module-old-binutils
...
test(tools): accept the q-suffixed mnemonics older objdump prints in annotate_module tests
2026-10-31 02:27:25 +01:00
dom
d06759420a
fix(tools): exclude private symbols from export annotations
2026-10-30 15:44:57 -04:00
Adrià
126f69be35
Merge pull request #13335 from Filip722/fix/tools-annotation-symbol-size-20261030
...
fix(tools): validate annotation symbol entry size
2026-10-30 18:58:30 +01:00
Arekatla Nishanth Chowdary
a29f22a765
test(tools): accept the q-suffixed mnemonics older objdump prints in annotate_module tests
...
GNU objdump before binutils 2.37 prints callq, jmpq and retq in 64-bit
AT&T output. annotate_module's STUB and BRANCH patterns already accept
the suffix, but the tests' instruction helper and the segment test's ret
match require the bare mnemonic, so with binutils 2.32 first on PATH 18
tests error with StopIteration and one fails. Accept an optional q
suffix, as the tool does.
2026-10-30 23:14:15 +05:30
Adrià
223b19ba0a
Merge pull request #13287 from PolkadotDom/fix/annotate-eip-references
...
fix(tools): wrap EIP-relative annotation addresses
2026-10-30 18:35:17 +01:00
Filip Michalski
04d8b1a0a6
fix(tools): validate annotation symbol entry size
2026-10-30 14:00:39 +01:00
dom
7b83ed2be8
test(tools): keep empty-segment ELF fixtures ordered
2026-10-30 08:01:03 -04:00
dom
23f92f6519
fix(tools): skip empty executable segments in annotations
2026-10-30 08:00:17 -04:00
dom
f6ed7549f1
fix(tools): exclude segment-based import annotations
2026-10-30 07:59:37 -04:00
dom
affc2a3e65
fix(tools): wrap EIP-relative annotation addresses
2026-10-30 07:47:47 -04:00
Adrià
388a33b2d1
Merge pull request #13102 from Queuse/codex/annotator-file-ranges-20261029
...
fix(tools): bound ELF annotation table reads
2026-10-30 12:03:56 +01:00
Adrià
95ef1d3d9a
Merge pull request #12952 from PolkadotDom/fix/annotate-zero-instructions
...
fix(tools): preserve zero-byte instructions in module listings
2026-10-30 06:32:48 +01:00
Queuze
82258ea17e
fix(tools): bound ELF annotation table reads
2026-10-29 22:14:12 -03:00
dom
52ea8c4534
fix(tools): preserve zero-byte instructions in module listings
2026-10-29 12:31:27 -04:00
dom
11872258e3
fix(tools): retain export aliases in module annotations
2026-10-29 08:19:08 -04:00
dom
4ababcbcfa
fix(tools): ignore no-op relocations in module annotations
2026-10-28 09:35:23 -04:00
Dean
6838a256b7
Merge pull request #11970 from pushkarreddyy/fix/annotate-module-test-skip-missing-objdump
...
test(tools): skip annotate_module tests when GNU objdump is unavailable
2026-10-28 22:35:07 +13:00
Henryisdjfunkyho
38ad367156
fix(tools): resolve dangling annotation links on Windows
2026-10-27 22:20:43 -07:00
Henryisdjfunkyho
ed57c22b92
fix(tools): reject aliased annotation reports
2026-10-27 22:19:36 -07:00
pushkarreddyy
953704f6e2
test(tools): skip annotate_module tests when GNU objdump is unavailable
2026-10-27 19:37:46 +05:30
StoneDC
051d00589c
fix(tools): preserve annotation input modules
2026-10-27 09:59:11 +08:00
fma-rc
d1ac8d9117
fix(tools): bound symbol names to DT_STRSZ and reject relocation tables that are not whole entries
2026-10-24 00:25:26 +02:00
fma-rc
d5e423a63a
fix(tools): find GNU objdump by name and refuse an LLVM objdump with a clear error
2026-10-22 00:45:18 +02:00
fma-rc
b069757f4e
fix(tools): keep TLS symbols out of the code map, validate relocation tags and disassemble every executable segment
2026-10-21 16:52:05 +02:00
fma-rc
72f397a374
feat(tools): name a relinked module's imports, stubs and exports in its disassembly
2026-10-21 16:46:55 +02:00
Dean