parseStream and decodeStream held a reference into the stream map
outside streamMutex while the guest's input callback ran. A callback
that deleted the handle, or a delete or new parse on another thread,
erased the stream under the running call.
- The map holds shared streams; each call keeps its own stream until
it returns, and the callback still runs outside streamMutex.
- A call that reaches a stream another call is still reading throws,
as the console's answer is not known; the debt entry says so.
- Tests: deleting the handle from the callback during a parse and
during a decode, and a decode re-entered from the callback.
- The test no longer requires parse operation 0x11 to throw.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Match PS5 firmware 13.42 module behavior by returning 0x80650012
(DECODE_ERROR) rather than 0x80650010 when input-control parse ends
before the frame header or encounters malformed marker data. Drop
the throw assertions for unsupported down scale and missing header
decodes in GuestJpegDecInputControl.cpp as requested in review.
Assisted-by: Antigravity:gemini-3.8-flash
The parse phase kept asking the callback for input until it ended. It now stops once the buffered bytes do not start with SOI, reach EOI or break the marker structure before a frame header, so a source that never ends cannot loop. The debt entry also notes that a stream stays in host memory when the work memory is freed without sceJpegDecDelete.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01SNqSvnFwRBz3D76n476yw6
The export takes the decoder handle, a 0x38-byte parameter block and an
image-info pointer. The block starts with an input callback and its
argument; the callback fills a {data, size} chunk and a negative result
or an empty chunk ends the input. Operation 0x10 parses the header and
fills the image info, and 0x20 continues the same stream, with a new
callback if given, and decodes into the image buffer. Bit 0 is the
decode mode. The decode checks match sceJpegDecDecode's and run before
any more input is read, and the result is the packed output size.
Both phases run through the same header, image-info and decode steps as
the memory-based calls, so the decode path is shared with
sceJpegDecDecode: its target checks and image writing move into helpers.
Read from libSceJpegDec.sprx, firmware 12.00, not measured on a console.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01SNqSvnFwRBz3D76n476yw6
AnyPS5 resolves a title's imports by NID, so a title that imports a system
function no library provides fails to load with an unresolved import. The
PS5 3.20 export inventory lists 193 such exports across 37 PS5 system
libraries AnyPS5 implements but does not provide.
Declare them as throwing stubs so those titles load and reach their next
blocker. Each declaration calls NotImplemented_nid_no_patch and returns 0;
none of them implements the function. Declarations with a credible
prototype use it and cite the source with a pinned commit, and the rest
are declared without parameters, which resolves the import without making
an ABI claim. The technical-debt files record the limitation per library.
libSceMbus and libSceSystemService are left out because pull request #7821
declares them. libSceAgc is left out because its exports are versioned, so
the 3.20 NID names a different symbol from the one AnyPS5 ships.
libSceAvPlayer.native is left out because it compiles libSceAvPlayer's
Export.cpp.
Names and NIDs come from the PS5 3.20 export inventory at
https://github.com/DNNDHH/PS5-3.20_Libs/tree/b2a77c09cd71c01f34c790cfbe98c751a13262ad
sceJpegDecParseHeader and sceJpegDecDecode threw for every down scale
other than 1. SharpProspero's JpegDec.cs documents the factors 1, 2, 4
and 8 and output dimensions that account for the down scale.
Decoder::Jpeg gains DecodeScaled, which decodes through libjpeg-turbo's
scaled inverse DCT, and ScaledDimension, its rounded-up output size.
sceJpegDecParseHeader reports the scaled output size; sceJpegDecDecode
checks the pitch and image buffer against it, writes the scaled image
and packs the output size into its result. A down scale of 1 still
decodes as before. Decode modes other than 0, other down scales and a
down-scaled CMYK or YCCK image still throw.
The JpegDec structures were libScePngDec's under new names. OpenOrbis
jpeg.h and SharpProspero JpegDec.cs agree on a 12-byte create param, a
0x30-byte decode param with a coefficient buffer, decode mode and down
scale, and a 0x24-byte image info that reports the coefficient memory
size, the suitable CSC attribute and the output size.
Accept the CSC attributes 1 and 2 that SharpProspero passes, fill the
output size, component count, coefficient memory size and suitable
attribute, apply the requested alpha, and throw for decode modes other
than 0 and down scales other than 1.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
