Slick Daddy
51c6b38978
Videodec2 opens FFmpeg with apply_cropping = 0, so the frame it reports is the coded picture and its crop fields describe the cropping rectangle. The coded size was derived from the frame size and the crop, which counted the crop a second time when it added up to a multiple of 16: a picture cropped four units at the top and four at the bottom was reported 16 rows taller than the coded picture, and every picture was then refused for a frame buffer that was sized for the coded picture. The frame size is the coded size, so the crop only fills the crop offsets. The fixture's sequence parameter set is also decoded with a crop of four units at the top and four at the bottom now, which covers the case in the guest test.
1.9 KiB
libSceVideodec technical debt
Unknown function info
-
sceVideodecCreateDecoder, sceVideodecDecode, sceVideodecDeleteDecoder, sceVideodecFlush and sceVideodecReset (libSceVideodec) - the structure layouts and the error codes follow shadPS4's PS4 library and its implementation, not measured on a PS5: the console's error for a rejected argument and its own version of the structures are unknown. The decoder runs through libSceVideodec2, which decodes H.264 with FFmpeg, and the picture is copied into the caller's frame buffer with the pitch aligned to 64 and the coded height, as the reference writes it
-
libSceVideodec (libSceVideodec) - the module's other two exports,
sceVideodecMapMemoryandsceVideodecQueryResourceInfo, are not provided, so a title that imports them fails to start
Functional
-
sceVideodecCreateDecoder (libSceVideodec) - the codec type is not checked and the decoder always decodes H.264, as the PS4 library does; the console's codec ids are not documented. A configuration without a maximum frame size is refused with the configuration error, and the resource information the caller passes is not used
-
sceVideodecDecode and sceVideodecFlush (libSceVideodec) - the picture information's video usability information (the tick rate, the sample aspect ratio and the colour description) stays zero, as the decoder does not report it, and the crop offsets are the decoded picture's crop halved, the unit the H.264 offsets use. The frame buffer holds the coded picture the decoder reports, so the rows the crop covers are in it and the caller crops them