tablefrogpillowandClaude Opus 4.8 dbf358ef81 fix(relinker): refuse write-execute PT_LOAD overlaps and bound the congruence check ...

Addresses the #12591 review. Because the Windows image ORs page permissions,
refuse a congruent overlap when one segment is executable and the other
writable and the later segment does not start on a page boundary, which would
otherwise share a read-write-execute page; the rule is applied on both loaders
so their acceptance decision matches. Bound the congruence check to the
file-backed part of the overlap and compare spans rather than walking the
implicit zero bytes of a large bss overlap.

Expand test_executable_segments.py: byte-congruent tail and bss overlaps
accepted with their trimmed sizes and no output overlap; a write-execute
overlap refused at an unaligned boundary and accepted at an aligned one with
the Windows image carrying no write-execute section; differing bytes, an
overlap past the later end, a non-zero file byte over the later segment's bss,
and a shared start address refused; and a no-overlap control. Keep only the
PPSA ids in the relinker.md note.

Co-Authored-By: Claude Opus 4.8 <[email protected]>

2026-10-29 23:24:38 +01:00

..

dev

fix(relinker): refuse write-execute PT_LOAD overlaps and bound the congruence check

2026-10-29 23:24:38 +01:00

user

Merge pull request #12621 from Ragbie/fix/windows-defer-needed-runtime-modules

2026-10-30 08:49:48 +13:00