From 0b555fa54d22b615cfaf42066cb305c035b7d5ca Mon Sep 17 00:00:00 2001
From: lucannez64 <58551020+lucannez64@users.noreply.github.com>
Date: Fri, 16 Oct 2026 10:17:29 +0200
Subject: [PATCH] Implement flashWindow in the X11 backend so attention
 requests don't abort the UX

NSApplication's attention timer calls -[CGWindow flashWindow], which X11Window
did not override; the base class raised an uncaught abstract-invocation
exception and LeagueClientUx aborted (and restarted every ~50s). Mark the
window as demanding attention through _NET_WM_STATE instead.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
---
 patches/cocotron.patch | 34 ++++++++++++++++++++++++++++++----
 1 file changed, 30 insertions(+), 4 deletions(-)

diff --git a/patches/cocotron.patch b/patches/cocotron.patch
index b7ee171..e06956b 100644
--- a/patches/cocotron.patch
+++ b/patches/cocotron.patch
@@ -3130,7 +3130,7 @@ index bfe3839a..2521ffd5 100644
  - (void) frameChanged;
  - (void) setLastKnownCursorPosition: (CGPoint) point;
 diff --git a/AppKit/X11.backend/X11Window.m b/AppKit/X11.backend/X11Window.m
-index f4925b66..67b084a0 100644
+index f4925b66..5ad2d1f7 100644
 --- a/AppKit/X11.backend/X11Window.m
 +++ b/AppKit/X11.backend/X11Window.m
 @@ -38,6 +38,34 @@
@@ -3692,7 +3692,33 @@ index f4925b66..67b084a0 100644
  }
  
  - (void) setHasShadow: (BOOL) value {
-@@ -559,7 +1028,29 @@ static NSData *makeWindowIcon() {
+@@ -488,6 +957,25 @@ static NSData *makeWindowIcon() {
+     _level = value;
+ }
+ 
++/* NSApplication's attention timer calls this for requestUserAttention:. The
++ * CGWindow base class raises an abstract-invocation exception, which aborted
++ * the whole LeagueClientUx process. Ask the window manager to mark the window
++ * as demanding attention instead. */
++- (void) flashWindow {
++    XClientMessageEvent event = {0};
++    event.type = ClientMessage;
++    event.window = _window;
++    event.message_type = XInternAtom(_display, "_NET_WM_STATE", False);
++    event.format = 32;
++    event.data.l[0] = 1; /* _NET_WM_STATE_ADD */
++    event.data.l[1] = (long) XInternAtom(_display, "_NET_WM_STATE_DEMANDS_ATTENTION", False);
++    event.data.l[3] = 1;
++    XSendEvent(_display, DefaultRootWindow(_display), False,
++               SubstructureNotifyMask | SubstructureRedirectMask,
++               (XEvent *) &event);
++    XFlush(_display);
++}
++
+ - (void) setOpaque: (BOOL) value {
+     _isOpaque = value;
+ }
+@@ -559,7 +1047,29 @@ static NSData *makeWindowIcon() {
      XRaiseWindow(_display, _window);
  }
  
@@ -3722,7 +3748,7 @@ index f4925b66..67b084a0 100644
      Atom wmState = XInternAtom(_display, "_NET_WM_STATE", FALSE);
      Atom hiddenState = XInternAtom(_display, "_NET_WM_STATE_HIDDEN", FALSE);
  
-@@ -615,6 +1106,12 @@ static NSData *makeWindowIcon() {
+@@ -615,6 +1125,12 @@ static NSData *makeWindowIcon() {
  }
  
  - (void) openGLFlushBuffer {
@@ -3735,7 +3761,7 @@ index f4925b66..67b084a0 100644
      CGLError error;
  
      CGLContextObj prevContext = CGLGetCurrentContext();
-@@ -666,6 +1163,7 @@ static int ignoreBadWindow(Display *display, XErrorEvent *errorEvent) {
+@@ -666,6 +1182,7 @@ static int ignoreBadWindow(Display *display, XErrorEvent *errorEvent) {
  }
  
  - (void) frameChanged {