mirror of
https://github.com/lucannez64/darling-lol.git
synced 2026-10-26 19:47:42 +00:00
lucannez64andClaude Opus 5.5
4370f375cd
Game process (ARAM Hexgate: 84 -> 127 FPS average, slowest stretches ~110): - Local pthread mutexes, condition variables and Mach semaphores are on by default in the game process only, with /tmp/rclol-no-local-* opt-outs. The main thread's darlingserver waits fell from 1.36 to 0.10 ms per frame. - Local semaphores: the count and the slot generation change in one compare-exchange, a destroy leaves a negative marker, the table is reset after fork, and names the table did not create go to the server. - Metal: drop identical re-binds (keyed on the Indium object, depth-stencil retained), pass blit resources by reference, and stop resetting vertex descriptors twice. - Core isolation of the main thread is opt-in (/tmp/rclol-core-isolation); it lowered FPS in its only match. - Optimized libc/libc++/Foundation overlays, AVX2 string primitives, real CPU topology and their installers and offline checks. Tools and docs: - tools/riot-match-capture: passive /proc sampler, user-space IP profiler and reports, plus a comparison against the game's netstats. - tools/riot-lsem-model and tools/riot-metal-bind-model: host models that extract the shipped code and check it. - tools/install-riot-metal-pair.sh installs Metal and Indium together. - Status, setup, testing and troubleshooting docs updated with the measured matches and the switch table; manifest file counts match the patches. Co-Authored-By: Claude Opus 5.5 <[email protected]>
68 lines
3.3 KiB
Bash
Executable File
68 lines
3.3 KiB
Bash
Executable File
#!/bin/sh
|
|
# Prove the model is not vacuous: re-break the fixed protocol in a copy of the extracted code, build the same model
|
|
# against it and show that the counters catch the bug. Nothing here touches the tree or the shipped library.
|
|
# Usage: sh sensitivity-check.sh (after run.sh; writes the outputs to build/riot-lsem-model)
|
|
set -e
|
|
here=$(cd "$(dirname "$0")" && pwd)
|
|
out=$(cd "$here/../.." && pwd)/build/riot-lsem-model
|
|
tmp=${TMPDIR:-/tmp}/lsem-sensitivity.$$
|
|
mkdir -p "$tmp"
|
|
|
|
make_variant() { # $1 = variant name, $2 = python replacement program
|
|
mkdir -p "$tmp/$1"
|
|
cp "$here/lsem-model.c" "$tmp/$1/"
|
|
python3 - "$out/lsem-shipped.inc" "$tmp/$1/lsem-shipped.inc" <<EOF
|
|
import sys
|
|
from pathlib import Path
|
|
src = Path(sys.argv[1]).read_text()
|
|
$2
|
|
Path(sys.argv[2]).write_text(src)
|
|
EOF
|
|
cc -O2 -pthread -o "$tmp/$1/lsem-model" "$tmp/$1/lsem-model.c"
|
|
(cd "$tmp/$1" && ./lsem-model) > "$out/sensitivity-$1-output.txt" 2>&1 || true
|
|
grep -E "FAIL|LSEM_MODEL checks" "$out/sensitivity-$1-output.txt" || true
|
|
}
|
|
|
|
echo "== broken tombstone: the destroy's wake value is a positive count again and the wait may take it"
|
|
make_variant broken-tombstone '
|
|
src = src.replace("(((old >> 32) + 1) << 32) | (unsigned int) LSEM_TOMB_VALUE",
|
|
"(((old >> 32) + 1) << 32) | 0x40000000u")
|
|
src = src.replace(""" if (v < 0) {
|
|
/* the destroy tombstone: a trap that resolved the slot while the destroy was in flight must
|
|
* report the death, never take the tombstone for a token */
|
|
(void) lsem_post_signal(post);
|
|
return KERN_TERMINATED;
|
|
}
|
|
""", "")
|
|
'
|
|
|
|
echo "== broken reuse: no new generation when a slot is reassigned and a value-only (32-bit) token CAS"
|
|
make_variant broken-reuse '
|
|
src = src.replace("unsigned long long fresh = (((old >> 32) + 1) << 32)", "unsigned long long fresh = ((old >> 32) << 32)")
|
|
src = src.replace(""" if ((unsigned int) __atomic_load_n(&s->pv.w.gen, __ATOMIC_ACQUIRE) != gen ||
|
|
__atomic_load_n(&s->name, __ATOMIC_ACQUIRE) != name) {
|
|
(void) lsem_post_signal(post); /* XNU signals the signal semaphore even when the wait fails */""",
|
|
""" if ((unsigned int) __atomic_load_n(&s->pv.w.gen, __ATOMIC_ACQUIRE) != gen) {
|
|
(void) lsem_post_signal(post); /* XNU signals the signal semaphore even when the wait fails */""")
|
|
src = src.replace(""" unsigned long long old = __atomic_load_n(&s->pv.pair, __ATOMIC_SEQ_CST);
|
|
if ((unsigned int) (old >> 32) != gen)
|
|
continue; /* the slot changed while we looked at it: the top of the loop reports it */
|
|
int v = (int) (unsigned int) old;
|
|
if (v < 0) {
|
|
/* the destroy tombstone: a trap that resolved the slot while the destroy was in flight must
|
|
* report the death, never take the tombstone for a token */
|
|
(void) lsem_post_signal(post);
|
|
return KERN_TERMINATED;
|
|
}
|
|
if (v > 0) {
|
|
/* take the token only if value and generation still belong to this object: the compare-exchange
|
|
* is on the whole pair, so a reused slot cannot hand its token to this waiter */
|
|
if (__atomic_compare_exchange_n(&s->pv.pair, &old, old - 1, 0, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST)) {""",
|
|
""" int v = (int) (unsigned int) __atomic_load_n(&s->pv.pair, __ATOMIC_SEQ_CST);
|
|
if (v > 0) {
|
|
if (__atomic_compare_exchange_n((int*) &s->pv.w.value, &v, v - 1, 0, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST)) {""")
|
|
'
|
|
|
|
rm -rf "$tmp"
|
|
echo "== done; outputs are $out/sensitivity-broken-*-output.txt"
|