diff --git a/NetKVM/CoInstaller/NetKVMnetsh.cpp b/NetKVM/CoInstaller/NetKVMnetsh.cpp index c2ce6401..92e1aaed 100644 --- a/NetKVM/CoInstaller/NetKVMnetsh.cpp +++ b/NetKVM/CoInstaller/NetKVMnetsh.cpp @@ -3,6 +3,7 @@ #include "RegAccess.h" #include "NetKVMAux.h" #include "RegParam.h" +#include //This is NetSH Helper GUID {D9C599C4-8DCF-4a6a-93AA-A16FE6D5125C} static const GUID NETKVM_HELPER_GUID = @@ -620,6 +621,7 @@ DWORD WINAPI _NetKVMShowParamInfoCmdHandler (__in PWCHAR /*pwszMachine*/, return ERROR_INVALID_PARAMETER; } } + __fallthrough; default: NETCO_DEBUG_PRINT(TEXT("PreprocessCommand returned: ") << dwPreprocessResult); return dwPreprocessResult; @@ -701,6 +703,7 @@ DWORD WINAPI _NetKVMGetParamCmdHandler (__in PWCHAR /*pwszMachine*/, return ERROR_INVALID_PARAMETER; } } + __fallthrough; default: NETCO_DEBUG_PRINT(TEXT("PreprocessCommand returned: ") << dwPreprocessResult); return dwPreprocessResult; @@ -782,6 +785,7 @@ DWORD WINAPI _NetKVMSetParamCmdHandler (__in PWCHAR /*pwszMachine*/, return ERROR_INVALID_PARAMETER; } } + __fallthrough; default: NETCO_DEBUG_PRINT(TEXT("PreprocessCommand returned: ") << dwPreprocessResult); return dwPreprocessResult; @@ -859,6 +863,7 @@ DWORD WINAPI _NetKVMShowParamsCmdHandler(__in PWCHAR /*pwszMachine*/, return ERROR_INVALID_PARAMETER; } } + __fallthrough; default: NETCO_DEBUG_PRINT(TEXT("PreprocessCommand returned: ") << dwPreprocessResult); return dwPreprocessResult; @@ -935,6 +940,7 @@ DWORD WINAPI _NetKVMRestartDeviceCmdHandler(__in PWCHAR /*pwszMachine*/, break; default: PrintMessageFromModule(g_hinstThisDLL, IDS_FAIL); + break; } tcout << endl; return dwError; @@ -944,6 +950,7 @@ DWORD WINAPI _NetKVMRestartDeviceCmdHandler(__in PWCHAR /*pwszMachine*/, return ERROR_INVALID_PARAMETER; } } + __fallthrough; default: NETCO_DEBUG_PRINT(TEXT("PreprocessCommand returned: ") << dwPreprocessResult); return dwPreprocessResult; diff --git a/NetKVM/Common/ParaNdis-Oid.cpp b/NetKVM/Common/ParaNdis-Oid.cpp index eb68db06..9ae4653b 100644 --- a/NetKVM/Common/ParaNdis-Oid.cpp +++ b/NetKVM/Common/ParaNdis-Oid.cpp @@ -10,6 +10,7 @@ * **********************************************************************/ #include "ParaNdis-Oid.h" +#include static const char VendorName[] = "Red Hat"; @@ -224,6 +225,7 @@ NDIS_STATUS ParaNdis_OidQueryCommon(PARANDIS_ADAPTER *pContext, tOidDesc *pOid) SETINFO(ul, NdisHardwareStatusReady); break; case OID_GEN_MEDIA_SUPPORTED: + __fallthrough; case OID_GEN_MEDIA_IN_USE: SETINFO(Medium, NdisMedium802_3); break; @@ -256,6 +258,7 @@ NDIS_STATUS ParaNdis_OidQueryCommon(PARANDIS_ADAPTER *pContext, tOidDesc *pOid) SETINFO(ul, pContext->MaxPacketSize.nMaxFullSizeOsRx); break; case OID_GEN_TRANSMIT_BLOCK_SIZE: + __fallthrough; case OID_GEN_MAXIMUM_TOTAL_SIZE: SETINFO(ul, pContext->MaxPacketSize.nMaxFullSizeOS); break; @@ -382,17 +385,29 @@ NDIS_STATUS ParaNdis_OidQueryCommon(PARANDIS_ADAPTER *pContext, tOidDesc *pOid) SETINFO(ul64, pContext->Statistics.ifOutErrors ); break; case OID_GEN_RCV_ERROR: + __fallthrough; case OID_GEN_RCV_NO_BUFFER: + __fallthrough; case OID_802_3_RCV_OVERRUN: + __fallthrough; case OID_GEN_RCV_CRC_ERROR: + __fallthrough; case OID_802_3_RCV_ERROR_ALIGNMENT: + __fallthrough; case OID_802_3_XMIT_UNDERRUN: + __fallthrough; case OID_802_3_XMIT_ONE_COLLISION: + __fallthrough; case OID_802_3_XMIT_DEFERRED: + __fallthrough; case OID_802_3_XMIT_MAX_COLLISIONS: + __fallthrough; case OID_802_3_XMIT_MORE_COLLISIONS: + __fallthrough; case OID_802_3_XMIT_HEARTBEAT_FAILURE: + __fallthrough; case OID_802_3_XMIT_TIMES_CRS_LOST: + __fallthrough; case OID_802_3_XMIT_LATE_COLLISIONS: SETINFO(ul64, 0); break; @@ -558,6 +573,7 @@ MAKECASE(OID_TCP_TASK_IPSEC_OFFLOAD_V2_UPDATE_SA) } return (const char *)buffer; } + break; } } diff --git a/NetKVM/Common/ParaNdis-TX.cpp b/NetKVM/Common/ParaNdis-TX.cpp index c989e36c..f21d30f2 100644 --- a/NetKVM/Common/ParaNdis-TX.cpp +++ b/NetKVM/Common/ParaNdis-TX.cpp @@ -1,4 +1,5 @@ #include "ndis56common.h" +#include CNBL::CNBL(PNET_BUFFER_LIST NBL, PPARANDIS_ADAPTER Context, CParaNdisTX &ParentTXPath) : m_NBL(NBL) @@ -514,7 +515,9 @@ bool CParaNdisTX::SendMapped(bool IsInterrupt, PNET_BUFFER_LIST &NBLFailNow) break; case SUBMIT_FAILURE: + __fallthrough; case SUBMIT_SUCCESS: + __fallthrough; case SUBMIT_PACKET_TOO_LARGE: // if this NBL finished? if (!NBLHolder->HaveMappedBuffers()) diff --git a/NetKVM/Common/ParaNdis-VirtQueue.cpp b/NetKVM/Common/ParaNdis-VirtQueue.cpp index f16b0b1b..75836621 100644 --- a/NetKVM/Common/ParaNdis-VirtQueue.cpp +++ b/NetKVM/Common/ParaNdis-VirtQueue.cpp @@ -1,5 +1,6 @@ #include "ndis56common.h" #include "ParaNdis-VirtQueue.h" +#include bool CVirtQueue::AllocateQueueMemory() { @@ -226,8 +227,10 @@ SubmitTxPacketResult CTXVirtQueue::SubmitPacket(CNB &NB) { KickQueueOnOverflow(); //Fall-through + __fallthrough; } case SUBMIT_PACKET_TOO_LARGE: + __fallthrough; case SUBMIT_FAILURE: { m_Descriptors.Push(TXDescriptor); diff --git a/NetKVM/Common/sw-offload.cpp b/NetKVM/Common/sw-offload.cpp index f2129459..2e9664fc 100644 --- a/NetKVM/Common/sw-offload.cpp +++ b/NetKVM/Common/sw-offload.cpp @@ -10,6 +10,7 @@ * **********************************************************************/ #include "ndis56common.h" +#include // till IP header size is 8 bit #define MAX_SUPPORTED_IPV6_HEADERS (256 - 4) @@ -285,11 +286,17 @@ QualifyIpPacket(IPHeader *pIpHeader, ULONG len, BOOLEAN verifyLength) break; //existing extended headers case 0: + __fallthrough; case 60: + __fallthrough; case 43: + __fallthrough; case 44: + __fallthrough; case 51: + __fallthrough; case 50: + __fallthrough; case 135: if (len >= ((ULONG)ipHeaderSize + 8)) { @@ -875,8 +882,11 @@ BOOLEAN AnalyzeIP6Hdr( { default: case IP6_HDR_NONE: + __fallthrough; case PROTOCOL_TCP: + __fallthrough; case PROTOCOL_UDP: + __fallthrough; case IP6_HDR_FRAGMENT: return TRUE; case IP6_HDR_DESTINATON: @@ -909,8 +919,11 @@ BOOLEAN AnalyzeIP6Hdr( } break; case IP6_HDR_HOP_BY_HOP: + __fallthrough; case IP6_HDR_ESP: + __fallthrough; case IP6_HDR_AUTHENTICATION: + __fallthrough; case IP6_HDR_MOBILITY: if(!SkipIP6ExtensionHeader(ip6Hdr, dataLength, ip6HdrLength, nextHdr)) return FALSE; diff --git a/NetKVM/DebugTools/NetKVMDumpParser/NetKVMDumpParser.cpp b/NetKVM/DebugTools/NetKVMDumpParser/NetKVMDumpParser.cpp index 8238193c..cf66513c 100644 --- a/NetKVM/DebugTools/NetKVMDumpParser/NetKVMDumpParser.cpp +++ b/NetKVM/DebugTools/NetKVMDumpParser/NetKVMDumpParser.cpp @@ -13,6 +13,7 @@ #include "stdafx.h" #include "NetKVMDumpParser.h" #include "..\..\Common\DebugData.h" +#include #ifdef _DEBUG #define new DEBUG_NEW @@ -817,6 +818,7 @@ CString tDumpParser::GetProperty(eSystemProperty Prop) s.Format("%s (Up time %d:%d:%d:%d)", buffer, days, hours, min, sec); } } + break; default: break; } diff --git a/NetKVM/NDIS5/Common/ParaNdis-Oid.c b/NetKVM/NDIS5/Common/ParaNdis-Oid.c index 47b91a52..aced5876 100644 --- a/NetKVM/NDIS5/Common/ParaNdis-Oid.c +++ b/NetKVM/NDIS5/Common/ParaNdis-Oid.c @@ -14,6 +14,7 @@ #ifdef WPP_EVENT_TRACING #include "ParaNdis-Oid.tmh" #endif +#include static const char VendorName[] = "Red Hat"; @@ -228,6 +229,7 @@ NDIS_STATUS ParaNdis_OidQueryCommon(PARANDIS_ADAPTER *pContext, tOidDesc *pOid) SETINFO(ul, NdisHardwareStatusReady); break; case OID_GEN_MEDIA_SUPPORTED: + __fallthrough; case OID_GEN_MEDIA_IN_USE: SETINFO(Medium, NdisMedium802_3); break; @@ -244,7 +246,9 @@ NDIS_STATUS ParaNdis_OidQueryCommon(PARANDIS_ADAPTER *pContext, tOidDesc *pOid) SETINFO(ul, pContext->MaxPacketSize.nMaxFullSizeOS * pContext->NetMaxReceiveBuffers); break; case OID_GEN_RECEIVE_BLOCK_SIZE: + __fallthrough; case OID_GEN_TRANSMIT_BLOCK_SIZE: + __fallthrough; case OID_GEN_MAXIMUM_TOTAL_SIZE: SETINFO(ul, pContext->MaxPacketSize.nMaxFullSizeOS); break; @@ -356,17 +360,29 @@ NDIS_STATUS ParaNdis_OidQueryCommon(PARANDIS_ADAPTER *pContext, tOidDesc *pOid) SETINFO(ul64, pContext->Statistics.ifOutErrors ); break; case OID_GEN_RCV_ERROR: + __fallthrough; case OID_GEN_RCV_NO_BUFFER: + __fallthrough; case OID_802_3_RCV_OVERRUN: + __fallthrough; case OID_GEN_RCV_CRC_ERROR: + __fallthrough; case OID_802_3_RCV_ERROR_ALIGNMENT: + __fallthrough; case OID_802_3_XMIT_UNDERRUN: + __fallthrough; case OID_802_3_XMIT_ONE_COLLISION: + __fallthrough; case OID_802_3_XMIT_DEFERRED: + __fallthrough; case OID_802_3_XMIT_MAX_COLLISIONS: + __fallthrough; case OID_802_3_XMIT_MORE_COLLISIONS: + __fallthrough; case OID_802_3_XMIT_HEARTBEAT_FAILURE: + __fallthrough; case OID_802_3_XMIT_TIMES_CRS_LOST: + __fallthrough; case OID_802_3_XMIT_LATE_COLLISIONS: SETINFO(ul64, 0); break; diff --git a/NetKVM/NDIS5/Common/sw-offload.c b/NetKVM/NDIS5/Common/sw-offload.c index 25317d72..9c0f8553 100644 --- a/NetKVM/NDIS5/Common/sw-offload.c +++ b/NetKVM/NDIS5/Common/sw-offload.c @@ -14,6 +14,7 @@ #ifdef WPP_EVENT_TRACING #include "sw-offload.tmh" #endif +#include // till IP header size is 8 bit #define MAX_SUPPORTED_IPV6_HEADERS (256 - 4) @@ -191,11 +192,17 @@ QualifyIpPacket(IPHeader *pIpHeader, ULONG len) break; //existing extended headers case 0: + __fallthrough; case 60: + __fallthrough; case 43: + __fallthrough; case 44: + __fallthrough; case 51: + __fallthrough; case 50: + __fallthrough; case 135: if (len >= ((ULONG)ipHeaderSize + 8)) { diff --git a/NetKVM/wlh/ParaNdis6-Oid.cpp b/NetKVM/wlh/ParaNdis6-Oid.cpp index 3dae7dd5..45d724e7 100644 --- a/NetKVM/wlh/ParaNdis6-Oid.cpp +++ b/NetKVM/wlh/ParaNdis6-Oid.cpp @@ -13,6 +13,7 @@ #include "ParaNdis-Oid.h" #include "ParaNdis6.h" +#include static NDIS_IO_WORKITEM_FUNCTION OnSetPowerWorkItem; @@ -475,6 +476,7 @@ NDIS_STATUS ParaNdis6_OidRequest( status = NDIS_STATUS_NOT_SUPPORTED; break; } + __fallthrough; case NdisRequestQueryInformation: if (Rules.Flags & ohfQuery) { @@ -898,6 +900,7 @@ static ULONG SetOffloadField( } break; case NDIS_OFFLOAD_PARAMETERS_NO_CHANGE: + __fallthrough; default: break; }