Input parameters that are missing, no mechanism for handling
abnormal input, for now, if user type `.\CollectSystemInfo.ps1 -?
(-help, --help)` or `.\CollectSystemInfo.ps1 noniput` , script
always runs without any warning output to the users.
It's not what we expected.
Solves: https://issues.redhat.com/browse/RHEL-50330
Signed-off-by: Dehan Meng <[email protected]>
If user operate 'ctrl+c' or exit powershell to break the
script-running, the Collecting_Status.txt would be opened and
cause the folder couldn't be removed/cleaned.
Solves: https://issues.redhat.com/browse/RHEL-50169
Signed-off-by: Dehan Meng <[email protected]>
Add an interruption handler. When the script is not finished
running, the generated file name could be marked with the
ongoing process, such as Collecting_Status.txt. and it would
be delete after completion. In this way, when the script is
waiting to be interrupted, it will be clearer to the user
which directory was interrupted.
Solves: https://issues.redhat.com/browse/RHEL-50169
Signed-off-by: Dehan Meng <[email protected]>
If we use DIRID 13 in Win10 drivers, we can't perform attestation signing
As Windows Server 2016 has build lower than 16299, we should
have DIRID 12 for Win10 drivers.
Resolve: https://issues.redhat.com/browse/RHEL-1214
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
HLK for Server 2025 fail INF Verification with the error:
The syntax 'DIRID 13 (CopyFiles)' was introduced in OS
version 10.0.16299, but DDInstall sections utilizing
the syntax will install on earlier OS versions. Those
DDInstall sections should be restricted to only install
on 10.0.16299 or higher using a TargetOSVersion decoration.
As Windows 10 before build 16299 is EOL and we don't
support it. This is ok, to have DIRID 13 in Windows 10
INF without TargetOSVersion decoration.
Resolve: https://issues.redhat.com/browse/RHEL-1214
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
build.bat will build the entire solution set one by one, which is single
threaded. On multi-processor builders in a CI/CD system, this is a bit
sluggish.
Enable msbuild -maxCpuCount on all msbuild commands, which will parallelize
msbuild actions where possible.
On an Azure Standard_DS2_v2 (i.e. a 2 vcpu builder) this change reduces
build_AllNoSdv.bat time from 12 min to 8 min.
Also, fix minor nit in top of file comments to reflect supported build targets,
which removes Win7, adds Win8.1.
Signed-off-by: Jon Kohler <[email protected]>
DVL builder from EWDK11 build logs with CodeQL results, but
HLK for Windows Server 2019 can't parse these logs. So we use
old DVL.exe to build logs for old HLK.
This commit required an additional binary from EWDK1903.
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
If due to any reason the test signing of the driver is requested
the build with EWDK may fail due to unknown file digest algorithm.
Make sure the default algorithm is always defined (sha256).
Signed-off-by: Yuri Benditovich <[email protected]>
EWDK is used to build drivers when run build scripts from the EWDK
environment or if EWDK_DIR var is set. Otherwise, drivers are built with
Visual Studio.
Signed-off-by: Ilya Rudakov <[email protected]>
Checking the current VS version and setting the supported version of the
platform toolset: v141 for VS2017 and v142 for VS2019, respectively. Set
PlatformToolset to AutoVSToolset in any UM app project where you want to
take advantage of auto target.
Signed-off-by: Ilya Rudakov <[email protected]>
Konstantin Kostiuk