Commit Graph
27 Commits
Author SHA1 Message Date
Kostiantyn Kostiuk 45e37d579a NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812)
Update _tagPacketOffloadRequest enum.

Signed-off-by: Kostiantyn Kostiuk <[email protected]>
2021-09-19 09:40:30 +03:00
Kostiantyn Kostiuk 9b4b3998c8 NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812)
Update _tagppResult enum.

Signed-off-by: Kostiantyn Kostiuk <[email protected]>
2021-09-19 09:40:30 +03:00
Kostiantyn Kostiuk 119238e3d3 NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812)
Update _etagHistoryLogOperation enum

Signed-off-by: Kostiantyn Kostiuk <[email protected]>
2021-09-19 09:40:30 +03:00
Viktor Prutyanov 3d54b6d5c0 NetKVM: fix possible arithmetic overflows (CA)
Value should be casted to wider type before calling operator.

Signed-off-by: Viktor Prutyanov <[email protected]>
2021-09-05 17:00:26 +03:00
Viktor Prutyanov ff9cf07442 NetKVM: fix comparison with wider type and uninitialized var (CodeQL)
- Comparison with wider type
- SM02323
- Uninitialized local variable

Signed-off-by: Viktor Prutyanov <[email protected]>
2021-09-05 17:00:26 +03:00
Yuri Benditovich 3642599e92 netkvm: preparation for NDIS 6.83 and USO support
Prepare the code to support NDIS 6.83 if such define will
be provided in a build (currently it is not).

Signed-off-by: Yuri Benditovich <[email protected]>
2021-08-04 10:45:24 +03:00
Viktor Prutyanov 52e72eb7da NetKVM: RHBZ#1979023: set NumRssQueues default value to 16
Win2022 HLK (NICStrictPropertyValidation) requires NumRssQueues
parameter default value to be 16 for 10Gbps adapters with
MSI-X support.

Signed-off-by: Viktor Prutyanov <[email protected]>
2021-07-22 10:35:18 +03:00
Viktor Prutyanov d177920610 NetKVM: RHBZ#1979024: restrict max VLAN ID to 4094
NetKVM treats VLAN ID = 4095 as well as IDs from 1-4094, that is frames
with ID = 4095 pass and others don't. According to IEEE 802.1Q, 4095
can't be valid VLAN ID. Also, Win2022 HLK assumes that NDIS accepts
ID <= 4094.

Signed-off-by: Viktor Prutyanov <[email protected]>
2021-07-19 08:45:05 +03:00
Yuri Benditovich 2212803c46 netkvm: correct the condition of send/receive possibility
Rename IsSendPossible to IsTxRxPossible and use fCurrentLinkState
instead of bConnected. Reuse this procedure in Rx path also, the
condition is the same for both directions.

Signed-off-by: Yuri Benditovich <[email protected]>
2021-04-01 15:11:46 +03:00
Yuri Benditovich 5ee294e61c netkvm: set fCurrentLinkState properly on init
Reuse ReadLinkState to obtain the link status from the device
and set properly fCurrentLinkState. When reporting the link
status on driver initialization we can't rely on bConnected
anymore as there is a possibility that we should hide the
link until VF is attached.

Signed-off-by: Yuri Benditovich <[email protected]>
2021-04-01 15:11:46 +03:00
Yuri Benditovich 251c5c81df netkvm: move ReadLinkState up for further reuse
Signed-off-by: Yuri Benditovich <[email protected]>
2021-04-01 15:11:46 +03:00
Yuri Benditovich e8d8decb27 netkvm: for failover virtio-net suppress link-up until VF bound
If the device reports standby feature but the protocol is not
installed yet or VF not present suppress the link-up indication
until the VF comes first time. After that the link-up follows
link status of the device until the driver is disabled.
Set packet filter (effectively enable the RX from the VF) after
the link-up is indicated.

Signed-off-by: Yuri Benditovich <[email protected]>
2021-04-01 15:11:46 +03:00
Yuri Benditovich 6c61bf8135 netkvm: add printouts for all the device features
Add missing printouts indicating offered device features.

Signed-off-by: Yuri Benditovich <[email protected]>
2021-02-08 11:52:00 +02:00
Basil Salman b22efbb8b8 VIRTIO_F_IOMMU_PLATFORM -> VIRTIO_F_ACCESS_PLATFORM
According to virtio v1.1 spec: https://docs.oasis-open.org/virtio/virtio/v1.1/csprd01/virtio-v1.1-csprd01.html
VIRTIO_F_IOMMU_PLATFORM was renamed to VIRTIO_F_ACCESS_PLATFORM.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1887843
Triggered by: https://lkml.org/lkml/2020/6/28/37

Signed-off-by: Basil Salman <[email protected]>
Signed-off-by: Basil Salman <[email protected]>
2020-11-12 10:24:25 +02:00
Yuri Benditovich bfad2ce34a netkvm: add CGuestAnnouncePackets::Clear and use it
Instead of calling destructor of CGuestAnnouncePackets
out of the blue, introduce Clear procedure and use it
from the destructor of the adapter context.

Signed-off-by: Yuri Benditovich <[email protected]>
2020-08-26 17:19:23 +03:00
Yuri Benditovich 015c07143e netkvm: make adapter cleanup implicit on destruction
Unpublish cleanup procedure and call it from destructor of
adapter's context.

Signed-off-by: Yuri Benditovich <[email protected]>
2020-08-26 17:19:23 +03:00
Yuri Benditovich c07b380014 netkvm: simplify init and cleanup of RSS parameters
Allocate RW lock in the constructor, if failed we will fail
the context initialization.
Free allocated CPU maps in the destructor, if allocated.
No need in "IsRSSinitialized" anymore.

Signed-off-by: Yuri Benditovich <[email protected]>
2020-08-26 17:19:23 +03:00
Yuri Benditovich 77ef2c1145 netkvm: remove explicit destruction of CParaNdisCX
Automatic call to destructor frees resources allocated
by the object (memory block for control commands).
If virtqueue was created it is also deleted by this call or
earlier implicitly by Shutdown().

Signed-off-by: Yuri Benditovich <[email protected]>
2020-08-26 17:19:23 +03:00
Yuri Benditovich 123ab06eff netkvm: remove explicit destruction of PCI resources
The automatic destructor unmaps mapped bars when needed.

Signed-off-by: Yuri Benditovich <[email protected]>
2020-08-26 17:19:23 +03:00
Yuri Benditovich 3f83048062 netkvm: use ctor/dtor for initialization of queues
Delete all the explicit initialization of receive queues
and the variable that indicates whether they are initialized.

Signed-off-by: Yuri Benditovich <[email protected]>
2020-08-26 17:19:23 +03:00
Yuri Benditovich 02221b124e netkvm: create/delete the context as C++ object
Change creation/deletion from alloc/free to new/destroy.
Remove some of explicit calls to constructors/destructors
of embedded objects.

Signed-off-by: Yuri Benditovich <[email protected]>
2020-08-26 17:19:23 +03:00
Yuri Benditovich 0626f060f1 netkvm: simplify CParaNdisCX
Make all possible initializations in the constructor.

Signed-off-by: Yuri Benditovich <[email protected]>
2020-08-26 17:19:23 +03:00
Yuri Benditovich 91594594cc nekvm: Use standard *JumboPacket instead of private MTU
*JamboPacket provides the same control over MTU.
The difference is that *JumboPacket includes ethernet header
size while the previous MTU does not.

Signed-off-by: Yuri Benditovich <[email protected]>
2020-08-26 09:54:52 +03:00
Pedro Justo (TEIXEIRA) cc40a4c918 Force NDIS SG DMA to use HAL v3 DMA APIs.
Signed-off-by: Pedro Justo <[email protected]>
2020-07-14 17:19:04 +03:00
Mohamed Mediouni 76ef17bf98 netkvm: Arm Windows support
NdisMAllocateSharedMemory maps memory as non cacheable on Arm Windows,
Given that Windows on Arm does not support unaligned accesses on uncached memory,
this behavior does result in crashes.

As such, use MmAllocateContiguousMemorySpecifyCache for the Arm64 architecture.
This choice is safe.

It's also to be noted that NdisMAllocateSharedMemory
ignores the isCached attribute anyway, and always
maps as cached on amd64.

This also allows us to remove the need for the Rx bounce buffer.

With this fix, networking w/ netkvm for Windows on Arm works fine.
(tested with QEMU emulator version 5.0.50 (v5.0.0-1065-g9f1f264edb))

Signed-off-by: Mohamed Mediouni <[email protected]>
2020-07-09 15:19:32 +03:00
Yuri Benditovich 8743d72f52 netkvm: ack STANDBY feature if reported by device
Signed-off-by: Yuri Benditovich <[email protected]>
2020-07-07 17:53:39 +03:00
Yuri Benditovich 954753b4d8 netkvm: renaming *-*.cpp to *_*.cpp
SDV is modern mode fails without any information if there
are source files with '-' sign in the name. This is
preparation change for further work with modern SDV.

Signed-off-by: Yuri Benditovich <[email protected]>
2020-05-09 23:48:03 +03:00